Andrew Kushnir comments

Results 312 comments of


                                            Andrew Kushnir

docs: modify the html tags

@aanchal88 it looks like the `aio/content/examples/ngmodules/e2e/src/app.e2e-spec.ts` file (and may be some other files too) also needs an update, since it uses a previous version in an element selector, see here:...

Connecting to websocket leaves app in unstable state

@yharaskrik thanks for reporting the issue! @JiaLiPassion quick question: do we keep the zone in unstable state while WebSocket connection is open? This is also partially related to #50285, where...

Use `globalThis` for `global`

@alan-agius4 do you see any risks from SSR standpoint?

Use `globalThis` for `global`

[TGP](https://test.corp.google.com/OCL:545581332:BASE:545580575:1688540989208:c5327fff).

Use `globalThis` for `global`

**Caretaker notes**: - I've set the target as "minor", since there might be a risk (pretty low though) in this change - the TGP is "green", but it still might...

refactor(common): deprecate isPlatform functions

[Presubmit](http://test/OCL:527914912:BASE:527914943:1682701298524:4ade1e6).

refactor(common): remove `supportScrollRestoration`

@atscott could you please help with the review to see if it's safe to land?

refactor(common): remove `supportScrollRestoration`

[TGP](https://test.corp.google.com/OCL:545853036:BASE:545852629:1688612896303:3594c7cb).

refactor(common): remove `supportScrollRestoration`

**Caretaker note**: TGP is "green", this PR is ready for merge.

fix(core): allow passing value of any type to `isSignal` function

This PR was merged into the repository by commit 165b8b647c39503b9fefd00188948cdc522c2c10.