Andrew Kushnir
Andrew Kushnir
@mhevery thanks for creating this ticket! Moving the `computeMsgId` function (and supporting code) to the `@angular/localize` and reversing the dependency (make `@angular/compiler` import `@angular/localize`) makes sense. This would also require...
Thanks @petebacondarwin 👍 I was looking at it more and realized that we do not have the `@angular/localize` package in Angular apps by default (it's brought in after running `ng...
> There is no real reason why the function should be owned by the compiler any more than the localize package. > Interestingly, it is only needed by the compiler...
I've replied on Pete's PR (https://github.com/angular/angular/pull/48178#issuecomment-1324423545), posting here for visibility as well: it looks like code duplication is the best option for now and we'll followup with extra cleanup to...
@mhevery sorry for the delay! We plan to take a look at the option described in https://github.com/angular/angular/issues/48163#issuecomment-1335805181 asap and update this thread with additional info.
Quick update: @clydin created a PR (https://github.com/angular/angular/pull/48799) which should allow the `@angular/localize` package no longer import the `@angular/compiler` package and the message digest algorithm implementation from the `@angular/compiler` package is...
@mhevery just wanted to share a quick update: the change from PR https://github.com/angular/angular/pull/48799 was released today as a part of Angular v15.1.2. Please let us know if that helped with...
@JoostK what do you think about closing https://github.com/ng-packagr/ng-packagr/issues/2398?
Closing this ticket for now, please reopen or create a new ticket when a repro is available. Thank you.
Caretaker notes: - this PR does not require a presubmit (this is an LTS-only change) - it looks like the `components-repo-unit-tests` CI job is failing for unrelated reasons