Andrew Kushnir

Results 312 comments of Andrew Kushnir

This PR was merged into the repository by commit abbaf8f6397a642f0d6ae39750b269c64b66bf2e.

[Presubmit (TGP)](https://test.corp.google.com/OCL:630265063:BASE:630264437:1714709068004:b65bcf89).

**Caretaker note**: [TGP is "green"](https://fusion2.corp.google.com/presubmit/630265063/OCL:630265063:BASE:630390464:1714748391907:4802b510/targets), this PR is ready for merge.

This PR was merged into the repository by commit a9460d08a0e95dcd8fcd0ea7eca8470af921bfe2.

[Global Presubmit](https://test.corp.google.com/OCL:626201892:BASE:626239048:1713500111099:42ea321c).

FYI, TGP contains a number of failures, which indicates that we should re-consider the rollout strategy (I've shared more info offline).

> this raises an interesting question of using component's id as a key in the cachedInjectors - it seems like it is not reliable enough. @pkozlowski-opensource agreed, the component ids...

(blocked by missing CLA, see https://github.com/angular/angular/pull/50701#issuecomment-1589375188)

Just a quick comment: the code around `ngSrc` input will change a bit in https://github.com/angular/angular/pull/50580, so we'd need to move the code from the getter to a different location (ngOnInit?).

[Presubmit](http://test/OCL:543591575:BASE:543591594:1687827084481:c96e848).