Andreas Borgen Longva

> Currently the macro generates quite a lot of code and is quite messy. Please come with feedback on the implementation of the macro. I think it would be useful...

Also, before finally merging this PR later on I think we should have quite a bit more tests. We should probably bikeshed over the name `cat` as well.. :upside_down_face:

> This is because the result matrix is filled using `Matrix::copy_from` which takes the second matrix as a reference. Could you perhaps circumvent this by creating an intermediate `MatrixSlice`? Roughly:...

@sebcrozet: could you please approve the workflow?

So at one point I actually hacked together a prototype for a fairly generic solution to concatenating matrices and vectors. The tricky part is to make it work properly with...

Since another user asked for concatenation on Discord, I wanted to add some points about my previous suggestion. It is built around a `Block` trait like this: ```rust trait Block...

That's an interesting proposition @sebcrozet! I've been thinking about this over the weekend, but I have not yet reached a clear conclusion. I'll outline my thoughts below. OK, so the...

Hah, that's a tricky one! Well spotted. What do you propose as a fix? Given this line here from #889: https://github.com/dimforge/nalgebra/pull/889/files#diff-5c897f17b8c12a9bccb0e81348ff1d428cf8c283929c2b8a1a77b7dbf098f856R69 ```rust if nrows.value() * ncols.value() != data.len() { ```...

Urgh, I have no idea what I was thinking there. I didn't want wrapping arithmetic - I wanted `saturating_mul`, and I thought there was a wrapper type for this as...

Note: this is being worked on in #1069.