Andreas Borgen Longva
Andreas Borgen Longva
Uhm, does `clippy` normally give warnings from code generated by macros in external crates? That seems... excessive? Did you enable any particular options?
[This comment](https://github.com/rust-lang/rust-clippy/issues/702#issuecomment-546156574) suggests that it's due to our use of spans in the `stack!` macro to improve error messages. We should fix this by just plastering `#[allow(clippy::all)]` in the macro-generated...
@danieleades: appreciate your input. However, in my 8 years of working with Rust, I've never seen clippy actually point out a real problem or bug, but I've seen plenty of...
I agree these methods could be useful. They're, however, quite difficult to get "right". In your code, you check for *exact* inequality. However, after one or more arithmetic operations, you'll...
You're right, there's already `is_identity` and `is_orthogonal`, both of which eventually boil down to `approx::relative_eq!`. I guess for consistency we could implement `is_unary` in the same way `is_orthogonal` is implemented....
As discussed in #1406, there are some design questions that we should carefully consider before we consider merging this PR.
The `point!`, `vector!` and `matrix!` construction macros are all usable in a `const` context, allowing you to construct `const` vectors, matrices and points. The `Unit`-related constructors are probably currently not...
I believe this was fixed in #1384 for the 4x4 case. I think it should work for the other cases. Can you confirm whether this fixes the issue for you...
I think perhaps this is better handled by the BLAS kernels, such as [`gemm`](https://docs.rs/nalgebra/latest/nalgebra/base/struct.Matrix.html#method.gemm). Would those work for your use case? I do have some thoughts on a much more...
Ah, damn, this is my fault. I think when I recently implemented `ReshapableStorage` for views, I didn't properly account for strides in cases like this. Thanks a lot for the...