Andreas Borgen Longva

Results 238 comments of Andreas Borgen Longva

If you have a use case for `push_matrix` where you explicitly want to filter out zeros, however, perhaps a separate method for this purpose would be appropriate?

I agree that the docs should be updated to reflect this. Specifically, for `From` in the top-level docs for the [convert module](https://docs.rs/nalgebra-sparse/latest/nalgebra_sparse/convert/index.html), and of course in the docs for `push_matrix`.

Ah, I see. I had totally forgotten that `matrixmultiply` does not support complex numbers, and I moreover did not know that it doesn't native support transposition. Thanks for explaining!

There's a lot to unpack here! I'd like to support your use case, but I'm not convinced that such a total redesign of the library is the right way to...

Oh, and for the record, I have some concrete thoughts on how the SPMM algorithm can be improved - we can discuss this when we've decided on the path forward....

Unfortunately I'm very pressed on time lately and have limited time to devote to this, therefore I must be a little blunt: I presented a number of reasons for the...

Given the age of this PR and its sweeping changes (and therefore conflicts with current `dev`), I think it might be hard to update. It's unclear to me if the...

`Makefile` no longer exists in `nalgebra`, so I believe that this PR is no longer relevant. I will therefore close it.

> This was brought back to my mind through the `hstack`/`vstack` PR. I am still interested in completing this and getting this PR merged. However I believe my work stopped...

Update: Sorry, I didn't see that you *had* in fact added some tests. I'll try to find time to look at them soon, but I'm very strapped for time at...