Andreas Borgen Longva comments

Results 238 comments of


                                            Andreas Borgen Longva

Feature: add filter and remove functions to CooMatrix

Hi @SeabertYuan, I appreciate the effort on this PR, but I must also admit I'm a little skeptical if these additions carry their own weight. Could you perhaps say something...

Feature: add filter and remove functions to CooMatrix

I see how these functions are useful to you. I'm just concerned that, well, they might not be useful to anyone else, as it seems to be a very niche...

Wrong result of nalgebra::base::Matrix::min() and ::max()

@sebcrozet: Note that this would give a `min`/`max` of `T::zero()` for matrices whose col or row count is `0` (which might frequently happen for edge cases of algorithms that need...

Wrong result of nalgebra::base::Matrix::min() and ::max()

What about `try_min()` returning an `Option`, and `min` panicking if the matrix has no elements? That way, you can choose a sensible value when the matrix is empty by e.g....

Wrong result of nalgebra::base::Matrix::min() and ::max()

Ah, yes, I also didn't consider the fact that we of course don't have a `RealField` bound here. Hmm, I think this could have very unintended consequences. Consider something like...

Wrong result of nalgebra::base::Matrix::min() and ::max()

On a separate note, changing the semantics of `min`, `max` would be a breaking change. It might be worthwhile to considering a separate PR that *only* fixes the initial bug...

Wrong result of nalgebra::base::Matrix::min() and ::max()

@w1th0utnam3: I think the `Ord`/`PartialOrd` split basically *is* the solution here. I know `nalgebra` implements `max`/`min` with `PartialOrd` alone for pragmatic reasons, but as we see from this discussion, this...

Wrong result of nalgebra::base::Matrix::min() and ::max()

@w1th0utnam3 : In the `non-try` case, I would suggest that it panics if it encounters `None`, and that it's documented that it's the user's responsibility that every element can be...