Hadrien Croubois
Hadrien Croubois
Yes, this is an optional dependency. Hopefully, the readme here, and openzeppelin's documentation can help you. Feel free to raise any issue you have with the current content in preparation...
This is on my todo list, I'll focus on that when I get back from vacations (august 20th)
The subgraph supports contract interface (events in particular) defined in [ERC-712](https://eips.ethereum.org/EIPS/eip-712) and [ERC-2309](https://eips.ethereum.org/EIPS/eip-2309). I'm not sure what events are emitted by 721A, but I'd argue its on them if they...
Can you share which version of `@graphprotocol/graph-cli` and `@graphprotocol/graph-ts` you are using ?
Also, did you get this package by cloning the repo, or did you get it through npm. If through npm, which version?
So if I understand correcly the answer is : There should not be any frontrunning possibility between the second verication and the bundle transaction being included, because the bundle transaction...
Thank you @GianfrancoBazzani. This looks good to me. @ernestognw, is there any chance that the emoji in the title is causing the CI issues ?
Looks mostly good. Before merging I'd like to discuss the prefixes. Currently we have: - `testXxxx` - `testSymbolicXxxx` - `checkSymbolicXxxx` I'd like use to consider alternatives, maybe - `testXxxx` -...
[12123b0](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5045/commits/12123b0255e9bd5abd7e7511975d26e79c326a7b) fixes the events, but is a breaking change. I don't think its a big deal (it wont be silent, compiler fail) ... but its not ideal. @ernestognw @frangio WDYT?
I honestly feel e0f5b71f24f1228affb5caea90e5469a07115bf7 reduces redeability ne consistency (instead of checking length in one place for both paths, we do it in two different places). I don't understand what the...