Hadrien Croubois

Results 626 comments of Hadrien Croubois

> I am unsure if I should open an issue for this. Yes please, open an issue describing the behavior desired as precisely as possible.

This is automatically handled by the compiler since 0.8.22.

As mentionned by @cairoeth, recent version of the compiler now automatically cache the value (and perform "unchecked" incrementation of the counter). IMO we should keep the code as clean as...

Signed part of this PR is merged as part of #5527. The unsigned part (more complex) is now planned for 5.4

@ernestognw I'm not a fan of this ERC. Particularly because it includes public setters (IMO that kind of standard should only include getters and events). Also There has been barelly...

We need a (simple) changelog entry that says the interface was added. For references, the changelog for 4.9.0 includes > IERC5313: Add an interface for EIP-5313 that is now final....

Note: ERC721 safeMint and safeTransferFrom rules fail because failure of the underlying `checkOnERC721Received` is not modeled in the `assert success (...);` description on liveness. AFAIK, we a few options (in...

I'm not sure why that happens, but clearly there is an issue here See [this](https://prover.certora.com/output/857050/ed327a47bcef450e8a8ef7e27492f6f5?anonymousKey=c35c617098bdfed45eb6160afd16ded0c0d30176). ![Capture d’écran du 2024-04-25 10-08-45](https://github.com/OpenZeppelin/openzeppelin-contracts/assets/2432299/db3d6b30-5897-49bf-b281-40e64d68c89c) ![Capture d’écran du 2024-04-25 10-10-39](https://github.com/OpenZeppelin/openzeppelin-contracts/assets/2432299/6595b216-e0d3-4d6c-90c5-f1969d1b73e9)

can we fix the slither thing @ernestognw

For the record, there is a "prototype" for this library in #4991 https://github.com/OpenZeppelin/openzeppelin-contracts/blob/fbf4ca5d17555cd2021b6e99717caa5ea5a4f835/contracts/utils/Call.sol