Hadrien Croubois

Results 626 comments of Hadrien Croubois

I am getting a similar issue with the following code ```cairo fn balance_of_batch(mut accounts: Array, mut ids: Array) -> Array { let mut balances: Array = ArrayTrait::new(); loop { let...

@ekpyron [This change to ERC-7751](https://ethereum-magicians.org/t/erc-7751-wrapping-of-bubbled-up-reverts/20740/3?u=amxx), if it was to happen (note, I'm a co-author of the ERC, so not unlikelly), would create a significant usecase of `abi.encodeError`. Depending on the...

My use-case is a bit complex, and one might argue that it comes from bad design on our end. --- OpenZeppelin provides a lot of functionalities in its different contracts...

In that you have to worry about storage compatibility of A and B, you can't call internal functions, you possibly have to do many checks... Basically, you are arguing that...

This should not have been close. The issue remains present and IMO a fix would be welcome.

@cameel can you reopen it ?

This issue is still relevant and is addressed by a pending PR. It should bot because for stale.

> This allows the derived contract to access and use those functions as if they were its own Private functions (and variable) are clearly not accessible from the derived contract...

``` function callAB() public { __myPrivateFunction(); // This works because it's inherited callA(); // This works too callB(); // This works too } ``` This does NOT work. Unlike internal...

Again, this issue is still relevant and is addressed by a pending PR. It should not be marked as stale.