Fabian Bastwöste
Fabian Bastwöste
This might be related to #252 .
Thanks for reporting! We will have to check if this behavior can really been seen as a bug or or is rather intended.
Looks more like there's a missing `B_GiveInvItems`. https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_STT_329_Dexter.d#L298-L300 changed to ```d CreateInvItems (self,itminugget,50); B_GiveInvItems (self, other, itminugget, 50); B_GiveInvItems (other, self, KalomsRecipe, 1); ```
Thanks for reporting! We will have to investigate this one as I don't see a bug in the scripts yet: https://github.com/AmProsius/gothic-1-community-patch/blob/b946ba1189a6937510bfbfaeff64a2df55d9cccb/scriptbase/_work/Data/Scripts/Content/Story/Missions/DIA_SLD_753_Baloro.d#L197-L236
We could also think about `.editorconfig` as an alternative: https://editorconfig.org/
Thank you for pointing out this behavior mismatch! It looks like you are playing the Gothic Mod Fix version of the game which isn't necessarily compatible with the patch (though...
https://github.com/AmProsius/gothic-1-community-patch/blob/2775fbc70322594ed1d00c96717143f0c2af5af7/scriptbase/_work/Data/Scripts/Content/AI/ZS_Human/ZS_AssessMonster.d#L36-L40 changed to ```d PrintGlobals (PD_ZS_CHECK); if C_NpcIsDown(other) { PrintDebugNpc (PD_ZS_CHECK, "...Monster kampfunfähig!"); return; }; //######## Ist NSC eine WACHE oder BOSS ? ######## ```
This bug seems to be present for the English language version of the game only. If the fix doesn't take effect when a mod fixes these strings, that's fine.
I suggest splitting this fix into separate Fixes and refactor them like this: ```d G1CP_ReplaceStringConst("NAME_LearnPostfixS", "skill point)", " skill point)"); /* * Find a constant string (case-sensitive) and replace it...
As stated by Vaana, this fix is incorrect and should be reverted in the upcoming release.