auth icon indicating copy to clipboard operation
auth copied to clipboard
verified publisher icon SocialConnect

Update Twitch API

Open slerdev opened this issue 4 years ago • 4 comments

Hey!

Type: bug fix

Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the Contributing Guidelines.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [ ] I wrote some tests for this PR.

Small description of change:

The old deprecated Twitch API was not working for us. It works with the following changes. For reference:

.. those that have not made requests to the v5 API before July 15, 2021 will no longer be able to access v5

Thanks :smiley_cat:

slerdev avatar Aug 16 '21 11:08 slerdev

The failing test case needs to be fixed.

ADmad avatar Aug 17 '21 05:08 ADmad

Thanks for the feedback. I suppose it means creating a mockClientResponse at testGetIdentitySuccess for TwitchTest.php?

I am not sure when I have time to do this.

slerdev avatar Aug 17 '21 09:08 slerdev

Thanks for the feedback. I suppose it means creating a mockClientResponse at testGetIdentitySuccess for TwitchTest.php?

Yes.

I am not sure when I have time to do this.

Then we'll have to wait until someone has the time :).

ADmad avatar Aug 17 '21 11:08 ADmad

Hi everyone! The test case was fixed here https://github.com/dv4mp1r3/auth/commit/914d838822a8fafe4ff60d90154279166a138c1c but I don't understand why this error appeared https://github.com/dv4mp1r3/auth/actions/runs/3952861608/jobs/6768979888#step:6:106 image

dv4mp1r3 avatar Jan 18 '23 21:01 dv4mp1r3