Andrew Kaster
Andrew Kaster
I think this is probably fine but can we enable on both CI instances? In both the GitHub actions CMake.yml and Meta/azure/Serenity.yml
I don't have an arm machine handy, but I'm curious, could you try passing -DBUILD_SHARED_,LIBS=OFF to CMake? I ran into similar issues trying to build for Android
Hey @demostanis could you rebase this on latest to make sure it still passes CI? looks like it fell through the cracks
You cannot compile Jakt with MSVC CL. use ClangCL instead. It must be at least ClangCL version 13, so that it can be built with `-std=c++20` and support all the...
The actual error you're seeing comes from the clang/gcc style warnings we pass without any checks, but if you remove those warnings you'll quickly run into other issues with e.g....
That would require CMake changes to find_package(Lagom) before trying to FetchContent. Given how quickly Lagom libraries change though, I'm not sure how valuable that would be. There's absolutely no promise...
Perhaps, but there are no versions of Lagom or Ladybird at the moment, only `trunk`. As a developer focused project, serenity does not have versions. See the rationale here https://github.com/SerenityOS/ladybird/issues/2#issuecomment-1177684116
I created #62 that adds some CMake install rules that more or less encode the "Lagom libraries are private impl libraries of serenity" concept in code. I personally think there's...
@chandlerc Are you sure that the bug reproduces when linking with ld64.lld? Your IR gets generated to asm with an AddrpAddStr linker optimization hint, but even on trunk that particular...
@Zaggy1024 can you rebase this on master? it looks good to go to me.