Andrew Kaster

Results 509 comments of Andrew Kaster

> the special case for ENABLE_USERSPACE_COVERAGE_COLLECTION was just a duplication of logic, right? Yes, it didn't link otherwise. If it links now we're good to go

Or for the large-ish capturing lambas, we can explicitly set the inline capacity for those functions so they scream loudly to a future auditor to look at a way to...

Is there a reason why passing a ArraySlice is preferred to a Jakt::Span? In serenity code we pass things as "ReadOnlyBytes" (an alias to `Span` a lot. edit: Ah I...

To confirm, this only happens when you bundle the prekernel, kernel, and rootfs into a qcow2 image? What's the output of `qemu-system-x86_64.exe --version` (or -v not sure the right arg...

Given some conversations on Discord, it looks like this is a Qemu 7.1 regression. Or more likely, Qemu defined some undefined behavior we were relying on in TCG in 7.1...

The workaround for this is to add the following to the Qemu args: ``` diff --git a/Meta/run.sh b/Meta/run.sh index 62080175f9..fa60a3c039 100755 --- a/Meta/run.sh +++ b/Meta/run.sh @@ -256,6 +256,7 @@ if...

This has conflicts again, for some refactors that I did this time :sweat_smile:

This is possible already, look at the advanced build instructions for serenity.

What website were you visiting when you hit this crash? Looks like there might be an object there that was garbage collected while it was still alive

Was this from latest master? NodeWrapper and WindowObject were removed from LibWeb last week