serenity
serenity copied to clipboard
Kernel: By default, don't dump regions when a userspace crash happens
Pro:
- Doesn't hold up the whole system for ten seconds on slow consoles while regions dump
- Doesn't clog up the console with information that is irrelevant to most developers, even when investigating crashes (the backtrace and crash reason is most often enough)
- Speeds up crash tests
- Old behaviour is still fully accessible if you want or need it Con:
- Region information might be impossible to obtain for flaky crashes
There is the DUMP_REGIONS_ON_CRASH debug macro which re-enables the old behaviour.
cc @timschumi
I think this is probably fine but can we enable on both CI instances? In both the GitHub actions CMake.yml and Meta/azure/Serenity.yml
@ADKaster excellent thought, that's exactly why it should remain as an option.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!