Andrew Kaster

Results 509 comments of Andrew Kaster

I'm also confused why the check that the target entry's document is not ever populated in general.. We set ever_populated to true in `populate_session_history_entry_document` step 6.7.1 when the document is...

Seems to be coming from here https://github.com/whatwg/html/blob/39ec6925e85b56c41f19f5bcb7f013c47be2a404/styles.css#L5

> What's the benefit and does that outweigh the cost here? I the the benefit here is if there's things you want to do with Cocoa/SwiftUI/UiKit and Lagom libraries, it...

Dropping this PR since the Xcode workflow seems unnecesssary for the most active macOS contributors. If we can find a reason to use Xcode over CLion and VsCode, might revisit...

The build with the default Unix Makefiles generator has been broken for a while, I think. Can you try using the `ninja` generator? ``` cmake -GNinja ```

We just recently (like, literally yesterday) added the calls to secure_getenv in that file. What OS is this? Does it have that function? Or are we just missing an include

so we don't have many people compiling for NetBSD, so this is kinda expected. FreeBSD is going ok it seems, as they have a port in their tree. fwiw FreeBSD...

That mmap should be just a ``` mmap(nullptr, HeapBlock::block_size, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, 0, 0); ``` where HeapBlock::block_size is 4096. https://github.com/SerenityOS/serenity/blob/a0dc9584de4dd5b8b355bed599ab5f54a5bb24b6/Userland/Libraries/LibJS/Heap/BlockAllocator.cpp#L58 perhaps NetBSD expects that the fd parameter...

about:srcdoc is a known issue https://github.com/SerenityOS/serenity/issues/23216 hitting issues in getaddrinfo/freeaddrinfo is unexpected though. It looks like we copy `struct addrinfo` into a vector from `getaddrinfo`, and then free the pointer...