Andrew Kaster

Results 509 comments of Andrew Kaster

Looks like this hit some gcc-13 related breakages. I'll probably hold off on that one then.

Missing a header for `environ` on macOS `/Users/runner/work/1/s/Userland/Libraries/LibCore/Environment.cpp:61:24: error: use of undeclared identifier 'environ'` https://dev.azure.com/SerenityOS/SerenityOS/_build/results?buildId=44741&view=logs&j=2351e412-c793-598f-27f8-72c4f2d55ba1&t=9c50333a-ada2-5596-d44b-d8dcee270ad2&l=99

@supercomputer7 do you have any time to look at this?

Looks like UBSAN hates your use of BigFraction. https://dev.azure.com/SerenityOS/SerenityOS/_build/results?buildId=44103&view=logs&j=2351e412-c793-598f-27f8-72c4f2d55ba1&t=ee375dfa-6b7d-514a-7789-3948d04c0dd3&l=267

This feature would also allow us to play the animation on https://beta.strawberry.rocks/ that follows the cursor.

I think we should be able to handle interpolation in a separate issue then, and keep this one about Element.animate rather than expanding the scope to the beta.strawberry.rocks page working...

Some poking around the linked issues suggests that `-DCMAKE_OSX_ARCHITECTURES=arm64` might succeed in getting a cross build going https://github.com/DataDog/libddwaf/blob/8a6e6e2b545c7075c17767bc4b43a5fd88d526f1/.github/workflows/build.yml#L72-L95

While GitHub Actions seems to have Apple Silicon hosted runners available, Azure DevOps doesn't yet. https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#software We'll either need to wait for ADO to get some apple silicon runners, or...

It looks like your test fails on your branch with clang, looking at the logs. can you verify that this works in that config?