Chris Li
Chris Li
@Andrew47 , thanks for addressing the comments and sorry for the delay in review. It looks like we are duplicating a lot of code in this PR and I am...
It turns out `One cannot pass an ID as entry point argument, which I think is why that function isn't an entry point function.`, will try a different fix
As mentioned in the tutorial, https://github.com/diem/move/blob/d5cb0578e5a8dc8afe2e6efb7504bb9ec1e63651/language/documentation/tutorial/README.md?plain=1#L34-L39 terraform, kubernetes, awscli will NOT get installed if running with `-ypt` because of https://github.com/diem/move/blob/d5cb0578e5a8dc8afe2e6efb7504bb9ec1e63651/scripts/dev_setup.sh#L765-L775 https://github.com/diem/move/blob/d5cb0578e5a8dc8afe2e6efb7504bb9ec1e63651/scripts/dev_setup.sh#L920-L940 @sblackshear do we still want to remove these code...
@sblackshear : https://github.com/diem/move/pull/73 is ready for review
Chatted with @tnowacki offline: - we don't want to embed the GitHub URL in the package metadata because URLs can be long and will increase the size of onchain data...
potentially leverage the events
> but I do worry that if we support amounts for some kinds of coin transfers and not others (e.g., transfers in Move calls) The proposal is to expose the...
> Does anyone have the PR that added transfer amount in the code, or has it been there a long time? Transfer amount is only available for `TransferSui` transaction, which...
> In the meantime, we are keeping older object versions and we don;'t have a purge policy yet. We can certainly have a policy that keeps a specified number of...
> to start, we only show amount for Sui objects by parsing them when generating events on FullNode. For non-Sui objects, it will be expensive to have parse all of...