move icon indicating copy to clipboard operation
move copied to clipboard

[Feature Request] simplify dev_setup script

Open sblackshear opened this issue 3 years ago • 3 comments

The dev_setup script installs many things (terraform, kubernetes, awscli, ...) that aren't needed to run Move. I think we should just need Rust + the .net and z3 deps for the prover.

sblackshear avatar Jan 28 '22 01:01 sblackshear

As mentioned in the tutorial,

https://github.com/diem/move/blob/d5cb0578e5a8dc8afe2e6efb7504bb9ec1e63651/language/documentation/tutorial/README.md?plain=1#L34-L39

terraform, kubernetes, awscli will NOT get installed if running with -ypt because of

https://github.com/diem/move/blob/d5cb0578e5a8dc8afe2e6efb7504bb9ec1e63651/scripts/dev_setup.sh#L765-L775

https://github.com/diem/move/blob/d5cb0578e5a8dc8afe2e6efb7504bb9ec1e63651/scripts/dev_setup.sh#L920-L940

@sblackshear do we still want to remove these code given that these flags are configurable?

666lcz avatar Feb 19 '22 02:02 666lcz

Yes, I think we should remove both the dev setup logic and the flags--better to have unused functionality deleted altogether rather than gated via flags IMO.

sblackshear avatar Feb 20 '22 15:02 sblackshear

@sblackshear : https://github.com/diem/move/pull/73 is ready for review

666lcz avatar Feb 22 '22 02:02 666lcz