sui icon indicating copy to clipboard operation
sui copied to clipboard

Published 20 hours ago • verified publisher icon MystenLabs

[explorer] Now wait for just one API call to display

Open apburnie opened this issue 2 years ago • 3 comments

Reduces Load Time in the Home Page by using getRecentTransactions API function.

Before:

https://user-images.githubusercontent.com/11377188/179023268-8e83852e-1ecf-4dcb-b398-658f5a00fc44.mp4

After:

https://user-images.githubusercontent.com/11377188/179023497-17ccc084-cdb4-4570-884c-1ff21796d93a.mp4

apburnie avatar Jul 14 '22 15:07 apburnie

@Andrew47 looks good. Although I am not sure how I can get the total tx count to pass the pagination component

Jibz1 avatar Jul 14 '22 17:07 Jibz1

@666lcz --> this PR is ready for another review. Following feedback, I've removed dependencies on unusual counts / transaction numbers. This means a different flow to how the Home Page works that is explained in added code comments.

apburnie avatar Jul 15 '22 14:07 apburnie

@Andrew47 , thanks for addressing the comments and sorry for the delay in review. It looks like we are duplicating a lot of code in this PR and I am wondering if there's better way to avoid that. Will take a closer look today

666lcz avatar Jul 19 '22 14:07 666lcz