Chris Li

Results 62 comments of Chris Li

Per feedback from @adeabiodun , we will implement the proposed solution and remove the existing filter box.

Here's an example object with struct: https://github.com/MystenLabs/fastnft/blob/3acaf2abcff381918fae4d4e2555ea8c7c0bf9ea/crates/sui-open-rpc/samples/objects.json#L75

related to https://github.com/MystenLabs/sui/issues/3611

@mystie711 Yes we need design for this. Added more details

@longbowlu to create an issue to track this on the backend

It turns out that the existing code already tolerates partial failure. I verified this by inserting an invalid transaction https://github.com/MystenLabs/sui/blob/c7e27a3f6daf9fcde05fcf88b3511a70eaf08d97/explorer/client/src/utils/api/DefaultRpcClient.ts#L33 and the transaction table is rendered correctly. It seems that...

@Jordan-Mysten , thanks for the feedback! All comments have been addressed

@patrickkuo , would you like to take this one for the JSON-RPC server?

@patrickkuo , assigning this to you for now since you implement the RPC endpoint. We should implement the rate limiting as a middleware. Let me know if you are not...

I believe this one has a higher priority than the doc and schema, because we don't want the server to be overwhelmed by malicious attackers or a heavy application cc...