James Garbutt

Results 209 comments of James Garbutt

@justinfagnani seems like the maintainer of `resolve` intends on adding support but that was a year or so ago. meanwhile it looks like most people have moved to this: https://github.com/webpack/enhanced-resolve...

~turns out this depends on inikulin/parse5#666~ depends on #3270 in fact

according to the docs, this is fine: ``` resolve("/some/path/to/folder", "module/dir", fn); ``` according to the code i then figured it should be impossible to never have a resolve context: https://github.com/webpack/enhanced-resolve/blob/651e57863e46afeccf1946b4275d7b2339152ed1/lib/Resolver.js#L267-L268...

@alexander-akait have updated with the types we talked about, mind taking another look? would be good if someone can trigger the CI too (first-time contributor 😬 )

Much of this is generated from a data set we then infer our types from. In this case and a couple others (e.g. `target`), I agree we should loosen the...

they shouldn't really be interchangeable. the type of a property isn't necessarily the same type as its attribute (since all attributes are strings). it is a widely used data set...

I can have a go at this, though question for @runem: do we keep any context around the original property definition? by the time our visitors get the assignment, the...

Been a while but iirc it means you have passed a string value (because you used an attribute binding) to a complex property (it is complex because in the class,...

@runem is this still a thing you haven't done in one of your branches yourself? its been a while since i started work on it so its very possible the...