James Garbutt

Results 74 issues of James Garbutt

Consumers should pretty much always use both eslint-plugin-lit and [eslint-plugin-wc](https://github.com/43081j/eslint-plugin-wc). To help make this more obvious and easier, we should publish a recommended config which depends on `wc`. We may...

help wanted

You could in theory have constructor parameters as long as they are optional: ```ts class Foo extends HTMLElement { constructor(a?: string, b?: string) { // fine } } ``` We...

With the latest postcss, it is possible (and quickly becoming common) to use a custom syntax to parse non-css files. This means via the postcss cli and other "pure" integrations...

Google used to maintain a library called `dom5` - a bunch of utils useful for traversing the parse5 AST amongst other things. Various other projects also implement modified versions of...

This should already be throwing warnings unless we disabled it explicitly. We should: - Change the level to `error` - Remove all possible `eslint-ignore` lines which currently disable this rule...

enhancement

https://github.com/inikulin/parse5/blob/f5dd91e2dd846ec5cfeda425c652ce47dffb0539/packages/parse5/lib/parser/parser-location-info.test.ts#L235-L290 This test currently creates its own location structure and asserts that it ends up in the resulting node. It currently passes because of its parameters being `any`. However, if...

testing

This is prep work for me turning the non-null-assertion rule on to `error`. Summary: * eslint:recommended wasn't enabled for `*.ts` so i have enabled it * unicorn wasn't used at...

Depends on #454 , draft until then. Fixes #377

We should set `@typescript-eslint/explicit-member-accessibility` to `error`. This will require that all members now have accessibility modifiers (e.g. `public`). Should be an easy one, though it will probably uncover a lot...

enhancement

We should enable the rule to disallow non-null assertions: ```ts foo!.bar!.baz; ``` from what i remember, we have quite a lot of these scattered around because of the whole "bootstrap"...

enhancement