James Garbutt

Results 191 comments of James Garbutt

that one in particular is because our placeholders are currently comments except in the case of attributes, then they are placeholder attributes. we need to implement better placeholder/substitution to account...

In your example, you don't use lit element, but lit directly. Lit 2.x does automatically bind if using `LitElement`, otherwise you have to set the `host` when rendering. With LitElement:...

Lit doesn't know or care what you're passing in that case as its just a data binding. If you pass a function, it'll get a function, etc. In those cases...

it isn't showing false positives as you should bind those functions _once_ in the constructor, not in your render method. otherwise, you'll be creating a function every time you render...

ah thats a fair point. we should probably point out that its still valid to use `bind` but outside the render method, i.e. beforehand in the constructor or somewhere

You should probably be doing: ```ts html`Link`; ``` so lit understands you're interpolating a value. im not sure how lit deals with trying to interpolate part of a value like...

yup sorry i took so long to get back to this, ill try have a look into this weekend. you're right, it should work fine

Sounds like a useful rule to me. I'll take a look when I'm back from vacation next week unless someone beats me to it 👍

i feel like if we do adopt these rules, they should probably exist as one to keep them well scoped to lit. a rule such as "file name matches class...

i wouldn't call it a bug (with browsers or with lit) but agree we should warn people about it. logically, its the same as: ```ts const node = document.querySelector('input'); node.value...