Fred Silberberg

Results 412 comments of Fred Silberberg

> What's needed to implement this? Is it just planning/dev cycles or is there something else that needs to be done? This issue as marked as Any Time and Needs...

> This can be automated. It can be automated, but it's a very ungraceful process if you find yourself in the scenario where you need multiple `when` clauses.

See also the discussion in ldm around making the existing switch expression an expression statement: https://github.com/dotnet/csharplang/blob/master/meetings/2019/LDM-2019-12-16.md#switch-expression-as-a-statement-expression.

> @333fred It's very similar to LINQ where at times you need to transform query expression into a method syntax and sometimes even into a loop statement. I'm not saying...

> @333fred , seems that mixing of value and type matching at the one level is not a good practice (may breaks possible compiler optimizations related with preffered type matching)....

Switch expression enhancements are covered by https://github.com/dotnet/csharplang/issues/3037.

> The proposal says "Prototype: Complete" at the top. Is that accurate? Is there a feature branch where a prototype lives? It is not complete.

> Is this meant as strongly as it reads? The proposal was put in the Likely Never milestone, and moved to the Rejected column in LDM triage. It's meant as...

## API Review * Most of the generator examples we've seen as motivating examples are v1 generators that, when factored into incremental generators, have perfectly fine performance. * Doesn't help...

### API Review * Analyzer config files are a hierarchy, but this operates on a single file. Is that good enough for analyzers? * Analysis might be "not enough keys...