Fred Silberberg
Fred Silberberg
> Because we no longer need to deal with trailing patterns for enumerable types. I'm not sure what you mean by this?
Partially discussed in LDM: https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-08-03.md#ref-fields-specification-updates
`non-private void` should almost certainly be required. They're part of a public api, and having them silently do nothing would break abstraction boundaries.
> I'm curious as to how the team weighs the relative benefits between "roles" and "extension implementation". It feels that without some additional effort in the runtime the two are...
I found the idea of `implicit` and `explicit` very interesting and forwarded your comment to our working group @sab39, thanks for the suggestion!
@lameox we're still looking for concrete perf numbers to drive this request. Particularly since some of the APIs referenced are in the compiler itself and haven't shown up on our...
I will defer to @CyrusNajmabadi's opinion on whether we should move forward with this then.
### API Review * APIs are approved * We should also add a SyntaxWalker variant with ``, to match `OperationWalker` * We need VB versions of these as well.
> Should I come up with a test plan for existing ... implementations? If you wanted to add tests as part of a PR, they would certainly be appreciated. Testing...
That seems fine @lameox.