alpharush

Results 318 comments of alpharush

@bart1e A separate PR would make it a little easier to review/ test in isolation

I think it'd make sense to ignore files that only contain imports but if a file imports this "container" we'd still want to warn for unused ones. I think leaving...

We determined that we don't want to identify "redundant" imports i.e. where a dependency can be satisfied transitively and instead only recommend removing absolutely unused imports

I will try to get this updated and ready for the next release (probably a couple weeks). In addition to some testing, I want to change the way the file...

Let's just keep the EVM printer in the existing bash script

@azpwnz It should return `False` when installation of `versions` are unsuccessful. That is, when `get_available_versions` does not contain all of the `versions`.

@0xGusMcCrae, thanks for taking the time tracking this down. Based off the duplicate function names, I suspect this may be fixed by #1625 but I need to double check

@smonicas this is similar to the issue outlined in https://github.com/crytic/slither/issues/1809#issuecomment-1492114159 ref https://github.com/crytic/slither/issues/1809

Any issue that can be fixed directly in Slither is fixed in https://github.com/crytic/slither/pull/2404 so this is blocked on https://github.com/foundry-rs/foundry/issues/7591

Hey, we'd like to upstream high quality detectors and any improvements in the false positive rate but it is a bit difficult to review such large PR's. Would you please...