solc-select icon indicating copy to clipboard operation
solc-select copied to clipboard

Published 20 hours ago • verified publisher icon crytic

`install artifacts` never returns false

Open 0xalpharush opened this issue 2 years ago • 3 comments

https://github.com/crytic/solc-select/blob/7b493c684aece2dc3e4f233fe044f23c1606be95/solc_select/solc_select.py#L72

0xalpharush avatar Jan 03 '23 13:01 0xalpharush

Hi @0xalpharush , I would love to contribute to the repo.

Could you suggest in which cases install_artifacts should return False? Would appreciate any details.

Thank you! :)

azpwnz avatar Jan 23 '23 17:01 azpwnz

@azpwnz It should return False when installation of versions are unsuccessful. That is, when get_available_versions does not contain all of the versions.

0xalpharush avatar Jan 24 '23 14:01 0xalpharush

@0xalpharush thank you for the explanation! I've prepared a PR with the changes https://github.com/crytic/solc-select/pull/151

azpwnz avatar Jan 29 '23 13:01 azpwnz