alpharush
alpharush
@dibakarsutradhar Can you share the full stack trace, slither version you're using, and source code (if possible)?
Could you try it without `--ignore-compile` and see if the issue still persists please?
@xxeonge I think @AaronLee22 got it worked here: https://github.com/crytic/slither/issues/2354#issuecomment-1982242185
Can you move the tests to `tests/unit/slithir` and run `pytest tests/e2e/detectors/test_detectors.py --insta update` please?
Similar assertion failure on https://github.com/delegatexyz/delegate-registry
Can we add tests?
You can use `// slither-disable-start reentrancy-no-eth` and `// slither-disable-end reentrancy-no-eth` to accomplish this
False positives are a frequent criticism of many static analysis tools. Solidity presents some unique challenges as it's not always clear what behavior will be of code that is called...
@mattsse This sounds like the behavior I described here https://github.com/gakonst/ethers-rs/issues/1995
This is not strictly blocked by https://github.com/ethereum/solidity/issues/15043 as additional stages would be trivial to add but it may be premature considering the original use case needs a semantic stage.