alpharush
alpharush
I haven't had a chance to look at this, but the detector was disabled in the latest release bc it was slow and flagging imports that were used https://github.com/crytic/slither/releases/tag/0.10.4
@DarkaMaul Maybe you will have a chance to give this a go
We may be able to use something like this to speed up the lookups https://pypi.org/project/intervaltree/ Also, we could look into something like Rowan's red-green trees
Can you give an example for when this isn't working? It works like `slither . --checklist --markdown-root https://github.com/ORG/REPO/blob/COMMIT/ ` normally
We should change this to consider all check of msg.sender against immutable variables or storage values that aren't able to be updated by non-privileged users as protected https://github.com/crytic/slither/blob/9a5b4f5cff9db6475c5badff18f9882180d5f344/slither/core/declarations/function.py#L1523-L1545
We aren't deduplicating by hash. It's possible the two code hashes have disjoint coverage so we can't just ignore a map if it's hash has already been seen. I do...
It's not being added to the corpus AFAICT bc that uses the codehash.
Do you mind uploading the CFG?
Echidna does not yet support MCOPY (see https://github.com/ethereum/hevm/issues/469). You can either use solc
Is the CFG and dominator graph correct?