Tomás Chor
Tomás Chor
I don't know how [5c8a763](https://github.com/CliMA/Oceananigans.jl/pull/2307/commits/5c8a763868bfcd244b84ad07122d11647f4f6994) almost passed (everything except for docs) but then a minor tweak on a doctest in [4e75ed3](https://github.com/CliMA/Oceananigans.jl/pull/2307/commits/4e75ed3f3222e25d51d24a4c74018e41cbe5d0ba) made a bunch of tests fail...
> I stopped buildkite [5c8a763](https://github.com/CliMA/Oceananigans.jl/pull/2307/commits/5c8a763868bfcd244b84ad07122d11647f4f6994) midway so it's not that there was only docs build that were failing.... Ah, I see. I hadn't noticed that.
Just to be clear, I'm not suggesting that we document experimental features to the level that we document mature ones. That'd be impossibly hard to maintain. But maybe a page...
> That way if users decide to experiment with a new feature they can also contribute their experience to the discussion. It might be more fluid and easier for everyone...
I took the liberty of creating this label and applying it to discussion https://github.com/CliMA/Oceananigans.jl/discussions/2345 I think if we tag these discussion appropriately so that it's easy for users to find...
I don't know a lot about this (@ali-ramadhan and @glwagner can give you a much clearer picture) but I think up until last week KernelAbstractions.jl straight up didn't support AMD....
Kinda. The current behavior is this https://github.com/CliMA/Oceananigans.jl/blob/470fd110a99b1967510979fbc313093dac060636/src/OutputWriters/netcdf_output_writer.jl#L302-L308 So the default is similar to what it was when this issue was posted, although I think it's formulated a little clearer now....
> I m wondering if this issue is solved in the new version It is! Although I'll move the masking from the model update to the output construction since it...
@navidcy @simone-silvestri can someone review this PR? I believe it may be ready to merge.
> I don't know the details here to provide useful feedback. Sorry... :( That's a good point. This PR changed from when it was first introduced and it's much simpler...