Tomás Chor

Results 266 comments of Tomás Chor

> Perhaps we are ready to revisit this? Yes, I was waiting for us to merge https://github.com/CliMA/Oceananigans.jl/pull/2842. Let's keep this open

> Before writing too much code can we discuss what we need and come up with a design together? Yes I agree. I am just pushing some code that I...

Now that the spacing functions are in place, I'm going to start working on this. (I'll update the top post with the information below.) The goal here is to add...

@jbusecke I hope you don't mind me recruiting your quick help here! I have a couple of questions regarding SGRID and xgcm, just to make sure I'm understanding things right:...

> Is this PR superseded by #2795? I think so. Although somehow this one seems to have fewer conflicts...

> Looks like this is a bad idea, so I'm closing. I'm not sure it's a bad idea. I've been having some issues with spurious waves in rotated domains and...

This issue got buried deep but I think we should resolve it. At this point I do think it's kind of late to keep the same name (`gravity_unit_vector`) and flip...

> If we change the name and that's a breaking change we will bump the version and all users will be happy or keep working with the Oceananigans version they...

This was resolved by https://github.com/CliMA/Oceananigans.jl/pull/2990 so I'm closing it

It seems that this issue didn't attention from the devs. @weiyuanlou were you able to make this work?