Tomás Chor

Results 265 comments of Tomás Chor

> Some doctests for `ImmersedBoundaryCondition` were converted to ordinary code blocks in #3692. It'd be nice to convert these back to doctests, if we can figure out how to filter...

> Hmm right... that filter stopped working. I think it's still working. I found an instance of it still being used here: https://github.com/CliMA/Oceananigans.jl/blob/a18b81d4c8776987d3cf619521941ba85000a1cb/src/MultiRegion/multi_region_grid.jl#L85-L97 > The filter matches with the _last_...

Personally I don't see a problem with warnings in the docstrings if that's how the code behaves. > Strikes me that we could also change the log level so that...

@xkykai so you're saying the fix for the instability exists already and it's just a matter of implementing it in #3188? Is that right?

Closed by https://github.com/CliMA/Oceananigans.jl/pull/3846