Oceananigans.jl icon indicating copy to clipboard operation
Oceananigans.jl copied to clipboard

Published 20 hours ago • verified publisher icon CliMA

Move to Julia v1.7

Open navidcy opened this issue 3 years ago • 11 comments

navidcy avatar Mar 05 '22 00:03 navidcy

Supercedes #2090

navidcy avatar Mar 05 '22 00:03 navidcy

Will this work flow work @navidcy @simone-silvestri ?

  1. Fix tests for Julia 1.7 and merge this PR
  2. Update CUDA + KernelAbstractions

Or, do we need to do 1. and 2. simultaneously?

glwagner avatar Mar 30 '22 19:03 glwagner

It'll work!

navidcy avatar Apr 05 '22 08:04 navidcy

@navidcy I'm pretty sure https://github.com/CliMA/Oceananigans.jl/pull/2502 fixed at least part of the failing tests here. I'm not sure how to deal with some of the conflicts so I'll leave the merging of main to you (unless you're okay with me taking a crack at it...)

tomchor avatar May 05 '22 03:05 tomchor

I’ll deal w it in a bit!

navidcy avatar May 05 '22 03:05 navidcy

merged main, let's see what happens

simone-silvestri avatar May 05 '22 03:05 simone-silvestri

I don't know how 5c8a763 almost passed (everything except for docs) but then a minor tweak on a doctest in 4e75ed3 made a bunch of tests fail...

tomchor avatar May 06 '22 13:05 tomchor

I stopped buildkite 5c8a763 midway so it's not that there was only docs build that were failing....

navidcy avatar May 06 '22 23:05 navidcy

I stopped buildkite 5c8a763 midway so it's not that there was only docs build that were failing....

Ah, I see. I hadn't noticed that.

tomchor avatar May 06 '22 23:05 tomchor

@simone-silvestri we may need to start working on this file-by-file...

navidcy avatar May 07 '22 05:05 navidcy

I'd like to help and hopefully clean up or simplify the tests along the way.

glwagner avatar May 07 '22 13:05 glwagner

I'll close it as stale. Julia v1.8 is coming up soon ;)

navidcy avatar Aug 17 '22 21:08 navidcy