stuartmorgan-g
stuartmorgan-g
> Since both the platform interface and plugin are changing, this patch is needed to make the tests pass See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins for the process to follow for multi-package changes.
Yes, see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-platform-interface-method-parameters
@blasten Ping on this review
Adding @camsim99 for Android review, per the new owners mapping.
@fbcouch Now that this has approval, you can go ahead and split out the platform interface part as a separate PR, and we can get that reviewed and landed to...
Sorry, I lost track of the state of this PR. The next step here would be to split the implementation package parts into a new PR. While from a compilation...
> so you are saying I should separate the `google_sign_in_x` parts into another separate PR, get that landed, then finally land the changes to `google_sign_in` itself? Yes, that's correct; once...
The platform interface changes have landed and been published, so the implementation parts can now be split out into a new PR.
Per the comment I just left in the issue, we should figure out if using Hybrid Composition would avoid the need for this hack.
> My app uses hybrid composition and I still see this error: > AndroidGoogleMapsFlutter.useAndroidViewSurface = true; In Flutter 3.0 the docs aren't correct any more; the behavior of Android platform...