stuartmorgan-g

Results 1163 comments of stuartmorgan-g
trafficstars

[camera]: Bump robolectric from 4.5 to 4.8.1 in /packages/camera/camera_android/android

@dependabot rebase

[url_launcher_android] Enables Android WebView to open non-https urls, e.g. `mailto:`, `sms:`

Thanks for the contribution! Capturing from discussion in Discord: > You probably need to do it with native unit tests, wrapping the intent call in a very thin wrapper class...

[url_launcher_android] Enables Android WebView to open non-https urls, e.g. `mailto:`, `sms:`

Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit...

[file_selector_windows] Fix the problem that the initial directory does not work after completing a file selection on windows

Thanks for the contribution! > I encountered this problem and there doesn't seem to be an related issue, so I'll just describe my issue here. Should I open an issue...

[file_selector_windows] Fix the problem that the initial directory does not work after completing a file selection on windows

> I have now created an issue and linked it, do I need to do anything else? The checklist in the PR description has all of the required steps for...

[file_selector_windows] Fix the problem that the initial directory does not work after completing a file selection on windows

> Hi, I am trying to write a test for the current use case, and I found that the existing tests are using a fake window, but in the current...

[file_selector_windows] Fix the problem that the initial directory does not work after completing a file selection on windows

@tgalpha Are you still planning on updating this to rename the wrapper (and thus the calls to it) per my comments above?

[file_selector_windows] Fix the problem that the initial directory does not work after completing a file selection on windows

> then making the tests compile again will be sufficient coverage. Ah, I misremembered the test class details; I thought we were intercepting the `SetDefaultFolder` call, so I thought that...

[webview_flutter] Add listener for scrolling and set the scrolled position programmatically in Android

I took an initial look at this; at a high level it looks good, but per this is a case where we should land it in parallel with an iOS...

[webview_flutter] Add listener for scrolling and set the scrolled position programmatically in Android

@TheVinhLuong Are you planning on updating this for the structural changes in the plugin (federation, Android conversion to a more Dart-based implementation), so that it would be ready as the...