stuartmorgan-g

Results 1191 comments of stuartmorgan-g

Thanks for the contribution! To set expectations here, this will likely take a little longer than usual for us to get to the review for given the scope of the...

> I based what I was doing off of the existing circle, marker, polygon, etc code. Are there native tests for those? See https://github.com/flutter/flutter/wiki/Plugin-Tests#faq-do-i-need-to-add-tests-even-if-the-part-of-the-code-im-changing-isnt-already-tested > If you could be more...

(Alternately, if the map is sufficiently inspectable, then Dart integration tests that actually validate that the map has the expected items added to it would give you end-to-end coverage that...

I only see integration tests in `google_maps_flutter_web`. Maybe there are files missing from your PR?

Oh, I see; I misread your comment. Yes, technically you couldn't break or remove *every* line of native code, but you could revert your entire `ios/Classes/` diff and just add:...

What's the status here (other than needing to be updated for federation, which moved some files); was this ready for another round of review, or were there still open questions?

@tuemaytinh1981 Please stop spamming maps PRs with this off-topic question.

Marking as a draft since this isn't fully review-ready yet.

Since this doesn't have an active owner, I'm going to go ahead and close it. If anyone is interested in moving forward with implementing this feature, forking this PR would...