stuartmorgan-g

Results 1263 comments of stuartmorgan-g

> ### Use case > Previous attempts of Impeller support broke the camera preview; see #150549. The revert has landed. However, no further actions were taken and the library did...

The question is still relevant though: what problem would be solved by migrating `camera_android`?

> I don't know if there is a statement that we don't need to support legacy plugins, the comment might be the only place someone stated as unnecessary? I don't...

I forgot we can't overload in Dart. Hmm. I expect code will be much more readable with the arbitrary de-duping, but the numbers are kind of weird. For writing code,...

> I'm seeing changes like this That change looks like a huge improvement in readability to me. > Even when there is only matching Dart method, it still isn't as...

> Beauty is in the eye of the beholder, I guess ;-) I didn't say beauty though, I said readability. Would you disagree that it's objectively true that accidentally swapping...

> I agree that accidentally swapping the parameters is harder in the new formulation. > > I'm not sure about the readability though. In the example that I gave, the...

Using ``` grep '?>' `find . -name *.dart | grep pigeons | grep -v pigeon/pigeons/` ``` (I'll need to spot-check that there's not a edge case that missed), the list...

@bparrishMines Assigning to you since the only thing left here is webview_flutter, which your work should address.

Thanks for the contribution! I did an initial skim of the app-facing and platform interface package changes, and the structure all looks good. > I am also curious whether adding...