stuartmorgan-g

Results 1306 comments of stuartmorgan-g

> Is it the case that this file just wasn't properly formatted in previous PRs Our CI enforces (with a few rare exceptions) autoformatting; what is checked in is by...

> I noticed in the contributing README that "changes that span multiple packages will need to be done in multiple PRs", so should this PR be closed and should individual...

> Do we actually want to increment the `google_maps_flutter_web` version if no real changes were made You can revert the changes to `google_maps_flutter_web`; if there are no changes to the...

> It seems the only thing holding this back from being able to be split into individual PRs are a number of [ProbeKVM errors](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718512830931064721/+/u/Run_package_tests/start_avd/Start_Android_emulator__android_34_google_apis_x64.textpb_/stderr?format=raw) in LUCI. This hasn't been reviewed....

> It sounds like this PR isn't responsible for ensuring the `tree-status` check passes, does that track? Yes, that's correct. `tree-status` is a live check tracking the state of the...

> I would think this PR makes sense to merge if we can get it to a point where we are only tying into native methods reflecting changes in indoor...

This was actually due to the `flutter drive` -> `flutter test` migration, rather than the LUCI migration. (It's related to LUCI only in that the LUCI migration allowed us to...

It's camerax as well; I don't remember the specific failures but presumably it needs the same permissions.

> In Flutter, experiments only work on the main/master channel. As a minor correction: in Flutter, experimental flags can be channel-gated, and [this particular flag is limited to `main`](https://github.com/flutter/flutter/blob/ac4e54c049e1d1ab45901d92c635702c2c07c4f7/packages/flutter_tools/lib/src/features.dart#L155). Flutter...

It's not clear to me that the Google Maps SDK supports this functionality. Are you aware of an API that allows what you are requesting here?