Steven Weerdenburg

Results 453 comments of Steven Weerdenburg

@rprouse If we're still considering ideas, a few things I'd like to suggest: - Better top-to-bottom support for generic APIs in assertions. There is some support already, but most things...

I think I recall reading a comment a while back from still another team member (@jnm2 ?) about an attempt to make the constraints generic. Seems like a popular ideal...

One other suggestion I'd like to make, keeping with the theme of improved memory usage, is to minimize calls to `string.ToLower()` for case-insensitive comparisons. Not a breaking change, but perhaps...

Looks like I dove in the deep end with https://github.com/nunit/nunit/issues/4067 😁

> https://github.com/nunit/nunit/issues/2843 is relevant. That was exactly the issue I had in mind @jnm2 , thanks!

I'd agree with that approach @manfred-brands (to use ordinal unless there's an indication the tests should be culture-aware) and it's also more inline with Microsoft's recommendations. Consistency is generally improved...

@jnm2 Interesting. I hadn't considered the idea of a "default culture". My thinking had been more along these lines: ``` if test is run from explicit culture-aware context use culture-based...

FWIW, I'd be willing to guess most string assertions used in practice will be equality assertions, for which the default is currently Ordinal. Only string startswith/endswith currently use a culture-aware...

Quite right, thanks @CharliePoole . You're right, SubstringConstraint is currently culture aware regardless of if Ignore case is specified Perhaps Ordinal-by-default would be more disruptive than I first thought

This issue seems thematically similar to @jnm2 's #3588