Steven Weerdenburg comments

Results 456 comments of


                                            Steven Weerdenburg

`NullReferenceException` during equality comparison of `IEnumerable` objects when `GetEnumerator()` returns `null`

My (perhaps solitary) opinion is that this is "not an nunit bug". It looks like .NET itself has likely chosen to treat this as a runtime concern instead of a...

`NullReferenceException` during equality comparison of `IEnumerable` objects when `GetEnumerator()` returns `null`

@ssrmm While I'm glad the custom comparer worked for you, one other option that I wanted to suggest for consideration by you is around the sense of "object identity". Without...

TestContext to implement IProgress<T> interface

I like this idea. It seems minimally intrusive yet provides a standard way to hook into incremental progress updates.

TestContext to implement IProgress<T> interface

@nunit/framework-team what are your thoughts?

Enforce consistent code styles between framework and other projects like the analyzers

Thanks @CharliePoole That had indeed been my thinking here: to start a chat about adopting any further style conventions for the framework project, and to configure tooling such as editorconfig...

Audit string equality comparisons and consider changes for v4

I did a cursory check for `EndsWith` a week or two ago, and I think most usages of that check for a constant string of symbols all in the ASCII...

Testfixture outside assembly is not executed

Thanks for the thorough code snippet and repro @MMark4 `SetupFixture` will only run the setup/teardown functions for tests within its namespace (or child namespaces). Your setup fixture doesn't have a...

Testfixture outside assembly is not executed

Thanks for catching that @mikkelbu

Store Timeout interval as a `TimeSpan` instead of an `int`

I'm starting to realize that a grep.app could only show a partial list of all open source references, let alone all references. I'm still curious about thoughts here, though. I...

Store Timeout interval as a `TimeSpan` instead of an `int`

Yes, somehow I'd forgotten that despite that in my day job we use and have extended nunit 😅 I'd like to reframe the question to focus on updating this to...