spacek531

Results 122 comments of spacek531

This is my dump. I was experimenting with the interactive console trying to get() and set() to `sharedStorage`. I believe I had just entered the command `context.sharedStorage.get("scenery-manager")`

I have removed the double increment for API version from this PR because #22048 is expanding in scope and not ready for merging, while this PR is ready (after review)

@Basssiiie You might be interested

Would it make sense to change the two new types CarPitch and CarBank to enums?

Where would you put MaxRotationDegrees? In ScEntity, ScVehicle etc., or a global? "How much you'll need to increment it before it does anything at all" is different per entity and...

The others do have a rotation property, it's a part of `EntityBase`.

If it isn't exposed in EntityBase then it has to be exposed individually for all the entity types it does affect. So it's a question of which is less desirable:...

~~How would you suggest sharing implementation? Is there a way to call `ScEntity::rotation_get()` from `ScVehicle::Register()`? I would not have to define `rotation_get()` and `rotation_set()` for every entity type?~~ I just...

Regarding making the rotation input range 0-31 and having a "max rotation degrees" value, I think that is less elegant than making the rotation 0-255 and having a "rotation degree...

The specific use case I am designing for is a plugin that reads user-defined animation data packed in the park and plays it back based on user-defined triggers. For example,...