Sam Clegg comments

Results 1093 comments of


                                            Sam Clegg

trafficstars

Unable to overwrite worker's onmessage when using MODULARIZE

Wait, if you are processing the data using native code then don't you have to copy the data out of the VideoFrame and into linear memory anyway? Why not copy...

Unable to overwrite worker's onmessage when using MODULARIZE

I'd be OK with landing #20235 but I think we should add a test/example and some docs about how to do it in the blessed way.

Returning null instead of empty string if a wrapped function returns null pointer

That sounds like the correct behaviour yes. Would you have time to send a PR? I think the code in question is in `src/library_ccall.js`

Returning null instead of empty string if a wrapped function returns null pointer

Actually it looks like there is already handling for this case: https://github.com/emscripten-core/emscripten/blob/645750cdb7a8cf2a9210f328ec2c0e5a3b1126e7/src/library_ccall.js#L33-L38 It looks like it should return 0 if getLastError returns NULL/0.

Returning null instead of empty string if a wrapped function returns null pointer

Sorry thats the handler to argument. The handler for returned strings just calls `UTF8ToString` which for some reason does, as you say, return empty string instead of `null`: https://github.com/emscripten-core/emscripten/blob/645750cdb7a8cf2a9210f328ec2c0e5a3b1126e7/src/library_strings.js#L126 I...

Returning null instead of empty string if a wrapped function returns null pointer

I think this is likely an historcal accident.

Returning null instead of empty string if a wrapped function returns null pointer

I'd still like to try and make this change if we can.. not sure if there is way to do it in a backwards compatible way..

Returning null instead of empty string if a wrapped function returns null pointer

I did some investigation and I'm not sure there is much we can win here. Do you have a use case where you need to distinguish between empty JS string...

Returning null instead of empty string if a wrapped function returns null pointer

Closing for now, feel free to re-open.

"local count too large" with large generated C++ function in debug mode

Does the problem go away when you run with `-O1` or `-O2`? Can you try also with `-sERROR_ON_WASM_CHANGES_AFTER_LINK -sWASM_BIGINT`? There are two possible causes here, firstly llvm could be generating...