Sam Clegg

Results 1076 comments of Sam Clegg
trafficstars

I'm not aware of any glib port I'm afraid. I imagine porting libffi might be tricky as IIRC it involves assembly code. Perhaps there is way to remove that dependency....

For a long time we (I) have been trying to come up with a place to put "contrib" ports like this. Simply adding everything and the kitchen sink to "tools/ports"...

The immediate problem I'd like to solve is how to add ports without adding: 1. New settings such as `USE_ZLIB` 2. Load on the CI system (its fine if we...

At least one related bug: https://github.com/emscripten-core/emscripten/issues/10048

Yes I pretty much agree with that. I do think that using a subdirectory would useful to indicate to two distinct and separate types of ports. I like `tools/ports/contrib` myself.

Also the current ports system isn't quite plug and play enough, you currently also need to add to the list in `__init__.py` when you add one. We should make it...

For now, adding to `__init__.py` is not a blocker IMHO

`emscripten-ports` is basically just a way to store the result of applying patches to an upstream release. if you don't have any patches then you don't need to use it...

If there is a historical reason I don't know it. I would have thought the point of creation of repository there is the point at which we need a patch....

In #20192. the technique used to receive the message should work regardless of whether we use `onmessage` or `addEventListener`, no? I.e. `var origOnMsg = self.onmessage; self.onmessage = ...` The user...