Sam Clegg

Results 1093 comments of Sam Clegg
trafficstars

> Hi @sbc100, it's possible to reproduce this. See my latest comment above. Sorry, I was specifically referring to the `__i53abi` issue mentioned in https://github.com/emscripten-core/emscripten/issues/21335#issuecomment-2338966756. Is that what you were...

> The `_wasmfs_opfs_set_size_file` function does not have an explicit `__sig`, so I don't know how (if?) that is working without it. We automatically generate `__sig` attributes for all builting JS...

Emscripten's TTY support is very basic. I would recommend completely avoiding `tcsetattr` and `stdin` and just writing a UI for that in JavaScript. Altneratively if you would like to work...

Is you final target nodejs rather than the web? If that is the case I think we can make `tcgetattr` work with `-lnoderawfs.js` fairly easily. When I suggested implementing this...

Yes, I think we (you?) can modify noderawfs (part of emscripten) so that this should work.

Can I ask what you use case is for using emscripten-built modules inside of node js?

I see, so you choosing wasm over a native node extension for portability reasons. BTW I wasn't suggesting you carry a local patch to `library_noderawfs.js` but rather send us a...

Why not just exclude the currently failing tests and submit #9937 as a starting point? Then you/we can followup by opening bugs, fixing tests and enabling the remaining ones at...

Great work on #9937 by the way! We've been thinking about moving towards a system like that downstream in emscripten too. If we ever get around it we may well...

OK I'll start by removing `master` from the proposals repos that I champoin (memory64 + extended const)