Sam Clegg comments

Results 1093 comments of


                                            Sam Clegg

trafficstars

Question: -sMAIN_MODULE=1 and -sEXPORTED_FUNCTIONS warning no longer valid?

BTW are you referring to symbols in the main module or symbols in the side module?

Closure has warnings with wasm2js

Upstream issue is here: https://github.com/google/closure-compiler/issues/4108

Async JS library funcs should not be marked for Asyncify transform

> We've [talked a bit](https://github.com/emscripten-core/emscripten/pull/19991#issuecomment-1668585499) about automatically wrapping async functions to do `Asyncify.handleAsync` so the user doesn't have to and only using promises, but there could be some potential downsides(mentioned...

Using WasmFS / OPFS from the main thread deadlocks on Safari

Is this a regression? (i.e. has this ever worked for you?)

evaluation of std::sin in C++ is slower than in JS directly

I suppose its possible that JS `Math.sin` is faster than the native `sin`. However it seems unlikely that the it would be bigger than the cost of call out to...

evaluation of std::sin in C++ is slower than in JS directly

I looks like you have shown that calling out to JS is much slower. EM_ASM_DOUBLE shouldn't be doing any runtime JS compilation of anything like that. I assume you are...

Unexpected error of proxyAsync with emscripten_init_websocket_to_posix_socket_bridge

That seems very odd. Can you uncommenting the `POSIX_SOCKET_DEBUG` line in `system/lib/websocket/websocket_to_posix_socket.c` and then rebuilding the library using `./embuilder build libsockets_proxy-mt --force`

Unexpected error of proxyAsync with emscripten_init_websocket_to_posix_socket_bridge

Is this something to do with the way the C++ lambda capture works for the bridgeUrl pointer? I would have though it would capture by simply copying the pointer.. but...

Show warning if export is not in ASYNCIFY_EXPORTS even for old Asyncify

Sounds good if its possible. Is it easy to detect "an exported method is using Asyncify ".. what does that mean exactly?

Dynamically creating a module in JS, function not found from linked module via dynamicLibraries

Yes, the way symbols were handled in dyanmic linking was changed in #18540. The idea is that the Module object should only contain the specifically EXPORTED_FUNCTIONS. All other symbols are...