Sam Clegg
Sam Clegg
Alternatively I suppose we could say that `emscripten_futex_wait` is simply not allowed in audio worklets? I suppose the reason that `__builtin_wasm_memory_atomic_wait32` is not supported there is because the designers of...
Sounds reasonable. Perhaps we can parameterize `futex_wait_main_browser_thread` with the location of the `_emscripten_main_thread_futex` value (and rename it): ``` // For the main browser thread and audio worklets we can't use...
Oh nice! Great minds think alike.
Yes we have thought about perhaps removing these using `tools/acorn-optimizer.mjs`... is that what you meant by "automatically drop asserts through the compiler". I'm not sure how easy it would be,...
I'm curious why non of our existing tests are hitting this error. Do we not run any browser tests with assertions disabled? Oh, this is only an issue in STRICT...
Could you perhaps add a `-sSTRICT` to one or more of the browser tests and verify that they then fail without this change? (Perhaps test_html5_core?)
Have these issues already been fixed or should we still try to land this change?
> Unfortunately this fails many tests in LTO and ThinLTO, e.g. `thinltoz.test_EXPORT_EXCEPTION_HANDLING_HELPERS` crashes in `wasm-ld`: > > ``` > wasm-ld: /b/s/w/ir/cache/builder/emscripten-releases/llvm-project/llvm/lib/MC/WasmObjectWriter.cpp:1814: uint64_t (anonymous namespace)::WasmObjectWriter::writeOneObject(MCAssembler &, const MCAsmLayout &, DwoMode): Assertion...
I don't know if the framework has many users. Certainly there only seems to be one very basic test that uses it: `test/core/test_tracing.c`. I believe this library was originally written...
Given that we have lsan for leak detection these days and it doesn't seem like there is anyone using this, I think this might be good feature to consider for...