Sam Clegg

Results 1115 comments of Sam Clegg

Looks like a real bug which I imagine was introduced in #21701. I can take a look at this tomorrow.

Actually I can't see how this is possible since `__emscripten_thread_crashed` and `__embind_initialize_bindings` should be included via https://github.com/emscripten-core/emscripten/blob/0e4c5994eb5b8defd38367a416d0703fd506ad81/tools/link.py#L488 and https://github.com/emscripten-core/emscripten/blob/0e4c5994eb5b8defd38367a416d0703fd506ad81/tools/link.py#L496. I'm having trouble reproducing as when I build with the above...

Anything you can do to reduce the side the reproducer would be great. For example, can you try other opt levels (e.g. `-O2` or `-O1`). You could also try to...

The `_emscripten_run_callback_on_thread` undefined symbol can be fixed by adding `-lhtml5.js`. This is needed because you added `-sSTRICT` which disables `AUTO_JS_LIBRARIES` by default.

You need to also add `-lhtml5` (to link against the native version of libhtml5). Alternatively you should add `-sAUTO_NATIVE_LIBRARIES`.

@brianpmaher what error are you seeing exactly? i.e. which symbol are you seeing as missing? Can you share the full set of link flags you are using along with the...

> According to my tests with the Godot Web threaded builds ([godotengine/godot#94725](https://github.com/godotengine/godot/issues/94725)), `wasm-metadce` is stripping the `_emscripten_thread_crashed` symbol (along few others), and this causes the closure compiler to complain (this...

@brianpmaher you should not need to add `__emscripten_thread_crashed` or `__embind_initialize_bindings` to `EXPORTED_FUNCTIONS`. Those are internal things that emscripten should absolutely handle itself. Something very odd must be going on with...

@brianpmaher I was able to reproduce you issue with `wasmPromiseResolve is not a function`. It was another side effect of building with `-sSTRICT`. I have a fix in flight but...

@tlively @juj @kripken @dschuff Thomas has made that argument that there is quite of benefit in being able to compare two version and get a good idea of how far...