P. L. Lim

Results 1963 comments of P. L. Lim

pre-commit.ci autofix

Thanks! Is your plan to get the tests in first via this PR, and have follow-up PR(s) to fix them? Or you plan to have the fixes as follow-up commits...

OK let's wait for Marten then. I am okay if you want to xfail the tests and just get those in, as long as we remember to open a follow-up...

@mhvk , should we add this to "known issues" for Quantity?

I mean, does switching to `ravel()` instead of `flat` solve your memory problem?

Okay, so fixing this isn't urgent for you then? You can use `ravel()` for the same improvement, if I understood correctly?

@braingram , is https://github.com/astropy/astropy/pull/16748 too much?

I am sorry I scared you back in 2021. It was not my intention. But my question from https://github.com/astropy/astropy/pull/11812#issuecomment-854965475 still stands. I think you can just use this: https://github.com/astropy/astropy/blob/32f2ba95479755808288160ea395bf0153d0316c/astropy/utils/data.py#L519 Is...

> If that makes sense. Ah, yes, it makes more sense now. But I also feel like it is not `astropy`'s job to engineer a generic file caching utility. The...