P. L. Lim

Results 1971 comments of P. L. Lim

Have to make sure CI does not fail when scipy is not installed. ``` astropy/nddata/tests/test_covariance.py:4: in from scipy import sparse E ModuleNotFoundError: No module named 'scipy' ``` Also, have to...

If the only difference is a `, dtype=int64`, maybe you can get away with using `+ELLIPSIS` https://docs.python.org/3/library/doctest.html#doctest.ELLIPSIS

Also the PR commit history here isn't clean anymore. Did you do this to rebase? ``` git fetch upstream main git rebase upstream/main ``` I see a merge commit in...

At least the commit history looks okay now but I didn't go through the diff again. Did you try ELIPSSIS for Windows?

Yes, you need a What's New entry in `docs/whatsnew/7.0.rst`. :)

Hmm. Maybe something got lost in the rebase. This is back. `ModuleNotFoundError: Use of 'astropy.nddata.Covariance' requires 'scipy.sparse' module!`

I think the stakeholders here are: * `nddata` maintainers * spectroscopy group (do you have a lead over there?)

Okay, I think I tagged the people who should do a initial pass of final review. Please ping them (or request me to) if they do not respond. Also does...

@taldcroft added this way back in https://github.com/astropy/astropy/pull/4423 . Not sure how we can deprecate that without issuing a ton of unsolicited warnings in the future. 🤔 I guess we can...